Closed
Bug 1669026
Opened 5 years ago
Closed 5 years ago
nsSHEntry.cpp: namespace alias decl 'dom' is unused
Categories
(Core :: Layout, task)
Core
Layout
Tracking
()
RESOLVED
FIXED
83 Branch
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: yashviknaithani)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
|
Bug 1669026 - nsSHEntry.cpp: unused namespace alias decl 'dom' removed. r?#static-analysis-reviewers
47 bytes,
text/x-phabricator-request
|
Details | Review |
Filling as a good first bug to learn workflows.
These line seems to be unused:
https://searchfox.org/mozilla-central/source/docshell/shistory/nsSHEntry.cpp#31
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by clang tidy http://clang.llvm.org/extra/clang-tidy/checks/misc-unused-alias-decls.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
"Bug 1669026 - nsSHEntry.cpp: namespace alias decl 'dom' removed. r?Olli Pettay, Peter Van der Beken"
|
||
Updated•5 years ago
|
Assignee: nobody → yashviknaithani
Status: NEW → ASSIGNED
|
|
||
Updated•5 years ago
|
Attachment #9180245 -
Attachment description: Bug 1669026 - nsSHEntry.cpp: namespace alias decl 'dom' removed. r?#static-analysis-reviewers → Bug 1669026 - nsSHEntry.cpp: unused namespace alias decl 'dom' removed. r?#static-analysis-reviewers
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8f21bf670f51
nsSHEntry.cpp: unused namespace alias decl 'dom' removed. r=sylvestre
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•